Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: adding integration tests #210

Merged
merged 8 commits into from
Oct 12, 2023
Merged

test: adding integration tests #210

merged 8 commits into from
Oct 12, 2023

Conversation

fstagni
Copy link
Contributor

@fstagni fstagni commented Oct 2, 2023

This PR adds few integration test for the pilot:

  1. The test simply installs the Pilot, getting configuration from lbcertifdirac70. The matrix variables are right now the python version (the version found on the WN) and the release version, for which here we take the HEAD of rel-v8r0 and integration branches of DIRAC. More variables to this matrix can be added, if felt requested.
  2. A test where DIRAC is sourced from CVMFS
  3. A test for pilot that is installed and then tries to match a job (from lbcertifdirac70)
  4. A test where DIRAC is sourced from CVMFS and tries to match a job
  5. A integration test for the LHCb extension
  6. A integration test for the LHCb extension, but using the vanilla Pilot DIRAC installer

These tests are only run on "push", so not in the pull requests (for a reason that I ignore, the base64 encoded certs used here are not properly passed in the environment of github actions runners for PRs). The tests ran on my fork: https://github.com/fstagni/Pilot/actions/workflows/integration.yml (after adding the correct secrets...).

The tests for LHCb are just an example. If you have your own Pilot extension, those specific tests can be added here: cc @sfayer @hmiyake @arrabito

@fstagni fstagni changed the title test: added an integration test test: adding integration tests Oct 3, 2023
@fstagni fstagni force-pushed the int_test branch 14 times, most recently from e824915 to 0483c3d Compare October 4, 2023 12:32
@fstagni fstagni force-pushed the int_test branch 8 times, most recently from 48b9efe to fa8a684 Compare October 5, 2023 10:46
@fstagni fstagni force-pushed the int_test branch 6 times, most recently from 2d48e78 to 88bf997 Compare October 6, 2023 13:57
@fstagni fstagni marked this pull request as ready for review October 6, 2023 14:34
@fstagni fstagni requested a review from atsareg October 6, 2023 14:50
@fstagni fstagni linked an issue Oct 6, 2023 that may be closed by this pull request
3 tasks
@arrabito
Copy link

Thanks for these tests. As CTA for now we don't have any pilot extension.

@fstagni
Copy link
Contributor Author

fstagni commented Oct 11, 2023

Thanks for these tests. As CTA for now we don't have any pilot extension.

Thanks for the info. What is the full command to start CTA pilots? To see if these tests cover you case.

@fstagni
Copy link
Contributor Author

fstagni commented Oct 12, 2023

I merge this, I see nothing wrong with it. No review, as usual for my PRs, can't wait forever.

@fstagni fstagni merged commit 130f522 into DIRACGrid:devel Oct 12, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support taking unpacked install from CVMFS
2 participants